Fix for single Activity format #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #197.
Bug: When creating a single activity course with moodleoverflow and going to "participant" within the course, an error occurs.
Problem: The lib function
moodleoverflow_extend_settings_navigationuses the$PAGEvariable to access certain variables like the context or the instance id of moodleoverflow. This does not work apparently, as a null exception is throwed.Solution: Instead of using the global variable $PAGE, the function now uses a "local" page variable from the function parameter
$settingsnav(The page variable is retrieved with$settingsnav->get_page()). This approach is used by other moodle plugin like the ratingallocate plugin from Learnweb.